Factor out all the common parameters of the various /relations apis #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently: "the ref partial doesn't support references using fragments yet" |
dbkr
added a commit
that referenced
this pull request
Mar 12, 2024
This writes up matrix-org/matrix-spec-proposals#3981 Hopefully this is relatively straightforward, apart from having to add the parameters and response field in all three places. I tried to factor these out but it seems references just aren't supported in the right places currently (see #1745 for my efforts). Path parameters can't be optional, so it can't be done that way either.
Merged
|
Hopefully I've fixed this in #1749, which I have now merged in here. |
richvdh
force-pushed
the
dbkr/relations_common_params
branch
from
5fe8d21
to
f16d804
Compare
|
Awesome, thank you for doing that. So this just needs a newsfile and it's ready to go? |
|
Ah no, I'll add a checklist to the description. |
|
sorry, I'm still thrashing this out with @zecakeh |
|
For info, I did a bit more refactoring in zecakeh@bd54781 to check more uses of |
|
Right, #1751 has landed, so I'm going to rebase this again |
This doesn't currently work, perhaps because the template needs to resolve refs? Also, the other instances of the params need to be replaced with the refs and the response fields probably should be factored out too.
richvdh
force-pushed
the
dbkr/relations_common_params
branch
from
089163a
to
5a442c4
Compare
Contributed by @zecakeh zecakeh@bd54781.
richvdh
approved these changes
Mar 19, 2024
dbkr
added a commit
that referenced
this pull request
Mar 19, 2024
* Spec for MSC3981 This writes up matrix-org/matrix-spec-proposals#3981 Hopefully this is relatively straightforward, apart from having to add the parameters and response field in all three places. I tried to factor these out but it seems references just aren't supported in the right places currently (see #1745 for my efforts). Path parameters can't be optional, so it can't be done that way either. * Missed schemas * newsfile * Actually it clearly isn't going to support markdown, is it? * grammar Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * grammar Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Clarity Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Clarity Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Typo Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * More clarity. Note this is counter what the MSC actually proposed to add, but I think it's clear that this is what it meant. --------- Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't currently work, perhaps because the template needs to resolve refs?
Things this PR needs:
Preview: https://pr1745--matrix-spec-previews.netlify.app