Upgrade CI scripts dependencies #1786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port to the use of the referencing library instead of the deprecated RefResolver Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
JSONPath is now a RFC instead of a draft so the major release was bumped Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
richvdh
reviewed
Apr 16, 2024
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
Looks sensible other than a couple of nits
| raise | ||
|
|
||
| try: | ||
| import referencing |
Member
There was a problem hiding this comment.
Since we depend on it, we should add this to requirements.txt, even though it will be pulled in as a transitive dependency in practice.
scripts/helpers.py
Outdated
| return yaml.safe_load(f) | ||
|
|
||
| def load_resource_from_uri(path): | ||
| """Load a JSON or YAML JSON Schema from a file:// URI. |
Member
There was a problem hiding this comment.
Suggested change
| """Load a JSON or YAML JSON Schema from a file:// URI. | |
| """Load a JSON or YAML JSON Schema, as a `referencing.Resource` object, from a file:// URI. |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow us to benefit from future fixes in JSON Schema validation.
Preview: https://pr1786--matrix-spec-previews.netlify.app