Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include information about additionalProperties in object tables #1798

Merged
merged 5 commits into from
May 2, 2024

Commits on Apr 23, 2024

  1. Improve comments in render-object-table

    Just documenting the current situation.
    richvdh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    55f7657 View commit details
    Browse the repository at this point in the history
  2. Pass additionalProperties and patternProperties into `render-obje…

    …ct-table`
    
    Previously, we were stripping `additionalProperties` and `patternProperties`
    from all objects except top-level objects. Obviously, this was no good for
    objects where a nested property contains such properties.
    
    Fixing that (in `clean-object`) *ought* to be simple enough, except that it
    turned out we were relying on the fact that would give us an "empty" entry in
    the array of types-to-render-tables-for returned by
    `resolve-additional-types`. (Normally, we don't want an object that only has
    `additionalProperties` to have its own table, since we just embed it in the
    parent table.)
    
    So, we need to add more logic to `resolve-additional-types-inner` to suppress
    such tables.
    
    This commit doesn't change the rendered output at all (verified via `diff`):
    it's just preparation for what comes next.
    richvdh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6f403f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6aabf11 View commit details
    Browse the repository at this point in the history
  4. changelog

    richvdh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b020b1d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Address review comments

    richvdh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f2ebb40 View commit details
    Browse the repository at this point in the history