Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve recommendation for how to form transaction IDs #1888

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Improve recommendation for how to form transaction IDs #1888

merged 2 commits into from
Jun 25, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 25, 2024 •
edited by github-actions bot
Loading

Fixes: #1706

Pull Request Checklist

Preview: https://pr1888--matrix-spec-previews.netlify.app

@Johennes
Improve recommendation for how to form transaction IDs
17dc1a2 
Fixes: matrix-org#1706
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes
Add changelog
2846bdf
@Johennes Johennes marked this pull request as ready for review June 25, 2024 09:09
@Johennes Johennes requested a review from a team as a code owner June 25, 2024 09:09
richvdh
richvdh approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@richvdh richvdh merged commit 7eda6ad into matrix-org:main Jun 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec gives bad advice on generating transaction IDs
2 participants
@Johennes @richvdh