Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of black to 22.3.0 #164

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Bump version of black to 22.3.0 #164

merged 1 commit into from
Apr 26, 2022

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Apr 25, 2022

This is in line with what synapse currently uses, and fixes a CI import error.

@H-Shay H-Shay requested a review from a team as a code owner April 25, 2022 23:57
@H-Shay H-Shay mentioned this pull request Apr 26, 2022
Merged
@H-Shay
Copy link
Contributor Author

H-Shay commented Apr 26, 2022

Not sure what's up with the mypy error-it can't be related to the changes here, I will investigate tomorrow.

@DMRobertson
Copy link
Contributor

Not sure what's up with the mypy error-it can't be related to the changes here, I will investigate tomorrow.

Guesswork: I think it's unhappy that parse_version can return two different kinds of version, and either

  • it doesn't think they have the <= comparison operator defined
  • or it doesn't think that the two types can be inter-compared(?)

There was a recent change to types-setuptools: which could be responsible: https://github.com/python/typeshed/blame/653f2c6ba4273618d4f0292b35938abb97cc42ed/stubs/setuptools/pkg_resources/__init__.pyi#L10-L11

Could try to prove this hypothesis locally by changing the version of types-setuptools in your virtualenv and running mypy.

squahtx
squahtx approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I'm guessing the mypy failure is due to deps changing under us and unrelated to this PR.

@H-Shay H-Shay merged commit ed863ba into main Apr 26, 2022
@H-Shay H-Shay deleted the shay/bump_black branch April 26, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@H-Shay @DMRobertson @squahtx