Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configured "mail" attribute when fetching mail addresses from LDAP #183

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

photoninger
Copy link
Contributor

@photoninger photoninger commented Sep 21, 2023

use the attribute from config to get mail address from ldap object instead of hard coded "mail".
Signed-off-by: Bernhard Lichtinger bernhard.lichtinger@lrz.de

use the attribute from config to get mail address from ldap object instead of hard coded "mail".
@photoninger photoninger requested a review from a team as a code owner September 21, 2023 11:20
Copy link
Contributor

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like in other spots we do properly use this attribute. 👍

Could you please sign-off on your changes?

ldap_auth_provider.py Outdated Show resolved Hide resolved
@photoninger
Copy link
Contributor Author

It looks like in other spots we do properly use this attribute. 👍

Could you please sign-off on your changes?

Done.

@clokep clokep changed the title Fix get mail address from LDAP - use attribute from config and not hard coded attribute "mail" Use configured "mail" attribute when fetching mail addresses from LDAP Sep 22, 2023
@clokep clokep merged commit 4d942e2 into matrix-org:main Sep 22, 2023
5 checks passed
@clokep
Copy link
Contributor

clokep commented Sep 22, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants