Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permalink highlighting - Highlight tile that matches ?at=$xxx #4

Closed
MadLittleMods opened this issue Feb 24, 2022 · 1 comment · Fixed by #123
Closed

Add permalink highlighting - Highlight tile that matches ?at=$xxx #4

MadLittleMods opened this issue Feb 24, 2022 · 1 comment · Fixed by #123
Labels
A-archive-room-view The view to look at a room day by day in the archive hydrogen Issues which involve https://github.com/vector-im/hydrogen-web T-Enhancement New feature or request
Milestone
Matrix Public Arc...

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Feb 24, 2022 •
edited

Similar to the permalink highlighting in the Gitter archives:

https://gitter.im/webpack/webpack/archives/2021/04/12?at=6074b67bd79539186153c59a

We can do the same in the Matrix public archives when adding ?at=$xxx to highlight the event tile in Hydrogen.

ex. http://localhost:3050/!HBehERstyQBxyJDLfR:my.synapse.server/date/2022/02/08?at=$xtyFUuYaHb63XsvEsdPAvQraCkimLCRPoZB6a6Cvy40

Considerations

What happens if the eventId isn't found on that given day? -> Split out to #124

  • With Gitter, we can easily lookup the eventId and redirect people to the correct day. But I don't think I want to do all of those round-trips to the homeserver to do this sort of thing.
  • In the Matrix public archives, I think I am just going to see if the event is in the given date displayed and if not, put a little warning overlay under the room header which says "Event wasn't found on this day" and link to /:roomIdOrAlias/event/:eventId which will actually do redirection work. This way, it's a choice by the user to take the action to jump to the correct day and it's explained what happened.

Dev notes

Related to #73 because of the different scroll behavior needed to center the message in the viewport.
@MadLittleMods MadLittleMods added the T-Enhancement New feature or request label Feb 24, 2022
@MadLittleMods MadLittleMods added the hydrogen Issues which involve https://github.com/vector-im/hydrogen-web label Sep 1, 2022
@MadLittleMods MadLittleMods added the A-archive-room-view The view to look at a room day by day in the archive label Oct 20, 2022
This was referenced Nov 2, 2022
Closed
Merged
MadLittleMods added a commit to element-hq/hydrogen-web that referenced this issue Nov 3, 2022
@MadLittleMods
Add a way to highlight tiles
dc6ab45 
Part of matrix-org/matrix-viewer#4
MadLittleMods added a commit that referenced this issue Nov 3, 2022
@MadLittleMods
Add permalink highlighting
78a1e0b 
Fix #4
This was referenced Nov 3, 2022
Merged
Open
MadLittleMods added a commit that referenced this issue Nov 3, 2022
@MadLittleMods
Add permalink highlighting - ?at=$xxx (#123)
5bae040 
ex.
```
http://localhost:3050/r/test-room1:my.synapse.server/date/2022/07/28?at=$O9fDg42JoSh9VdcL820FDUS0Gi_CkPt_hrN1pK1fPEY
````

Fix #4

Split out from #121
@MadLittleMods MadLittleMods mentioned this issue Nov 3, 2022
Open
This was referenced Nov 11, 2022
Open
Closed
@bkil
Copy link

bkil commented May 29, 2023

Improvement: #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-archive-room-view The view to look at a room day by day in the archive hydrogen Issues which involve https://github.com/vector-im/hydrogen-web T-Enhancement New feature or request
Projects
None yet
Milestone
Matrix Public Archive v0.1.0
Development

Successfully merging a pull request may close this issue.

Add permalink highlighting - ?at=$xxx matrix-org/matrix-viewer
2 participants
@MadLittleMods @bkil