Prevent Cloudflare from overriding our own 504 timeout page #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explored in https://gitlab.matrix.org/matrix-public-archive/deployment/-/issues/2 > Cloudflare returns an Cloudflare-branded HTTP 502 or 504 error when your origin web server responds with a standard HTTP 502 bad gateway or 504 gateway timeout error: > > *-- https://developers.cloudflare.com/support/troubleshooting/cloudflare-errors/troubleshooting-cloudflare-5xx-errors/#502504-from-your-origin-web-server* The only way to disable this functionality is to have an Enterprise Cloudflare plan and use the `Enable Origin Error Pages` option: > Enable Origin Error Pages > > When Origin Error Page is set to “On”, Cloudflare will proxy the 502 and 504 error pages directly from the origin. > > Requires Enterprise or higher So instead of dealing with that headache, we're just working around this by responding with a 500 error when we timeout. Should be good enough I think. The user won't know any difference but may affect what Search Engines think. Not sure they care about the distinction since the page is slow to respond anyway which they punish.
MadLittleMods
added
T-Defect
MadLittleMods
commented
May 11, 2023
| // | ||
| // We want to show our own timeout page because it has more information about what | ||
| // went wrong (e.g. which external Matrix API requests were slow). | ||
| res.status(config.workaroundCloudflare504TimeoutErrors ? 500 : 504); |
There was a problem hiding this comment.
This should be using config.get('workaroundCloudflare504TimeoutErrors')
Fixed in #229
MadLittleMods
added a commit
that referenced
this pull request
May 11, 2023
MadLittleMods
added a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent Cloudflare from overriding our own 504 timeout page
Explored in https://gitlab.matrix.org/matrix-public-archive/deployment/-/issues/2 (internal deployment issue)
The only way to disable this functionality is to have an Enterprise Cloudflare plan and use the
Enable Origin Error Pagesoption:So instead of dealing with that headache, we're just working around this by responding with a 500 error when we timeout. Should be good enough I think. The user won't know any difference but may affect what Search Engines think. Not sure search engines care about the distinction since the page is slow to respond anyway which they punish.