Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSC3819: Allowing widgets to send/receive to-device messages #57

Merged
merged 3 commits into from Jul 13, 2022
Merged

Implement MSC3819: Allowing widgets to send/receive to-device messages #57

merged 3 commits into from Jul 13, 2022

Conversation

robintown
Copy link
Member

@robintown robintown requested a review from a team as a code owner June 22, 2022 19:59
@robintown robintown marked this pull request as draft June 22, 2022 20:01
@robintown robintown removed the request for review from a team June 22, 2022 20:01
This was referenced Jun 22, 2022
Open
Merged
@robintown robintown marked this pull request as ready for review June 29, 2022 16:06
@robintown robintown requested review from a team, germain-gg, dbkr and SimonBrandner and removed request for a team June 29, 2022 16:07
@SimonBrandner SimonBrandner removed their request for review June 29, 2022 16:47
@SimonBrandner
Copy link

SimonBrandner commented Jun 29, 2022 •
edited

/me doesn't feel like he knows enough to review this one 😅

@turt2live
Copy link
Member

/me doesn't feel like he knows enough to review this one 😅

it's a great opportunity to learn then :) that's why the review requests are randomly assigned.

@SimonBrandner
Copy link

SimonBrandner commented Jun 29, 2022 •
edited

/me doesn't feel like he knows enough to review this one sweat_smile

it's a great opportunity to learn then :) that's why the review requests are randomly assigned.

felt like stalling the review 😅 though yes, there are multiple people assigned here

(GH is driving me mad)

@SimonBrandner SimonBrandner reopened this Jun 29, 2022
SimonBrandner
SimonBrandner approved these changes Jul 2, 2022
View reviewed changes
Copy link

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what it should do; not that I would feel confident about understanding it

src/models/WidgetEventCapability.ts Show resolved Hide resolved
src/ClientWidgetApi.ts Show resolved Hide resolved
@robintown robintown merged commit f35e37a into matrix-org:master Jul 13, 2022
@robintown robintown mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg was automatically assigned from matrix-org/element-web-reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robintown @SimonBrandner @turt2live