Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum node version to 14 #192

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Bump minimum node version to 14 #192

merged 1 commit into from
Jan 19, 2022

Conversation

Gnuxie
Copy link
Contributor

@Gnuxie Gnuxie commented Jan 18, 2022

Needed to merge #186 & node 12 is approaching EOL.

@Gnuxie Gnuxie self-assigned this Jan 18, 2022
Gnuxie added a commit to matrix-org/pipelines that referenced this pull request Jan 18, 2022
richvdh pushed a commit to matrix-org/pipelines that referenced this pull request Jan 19, 2022
Needed to merge #186 & node 12 is approaching EOL.
Copy link
Contributor

@Yoric Yoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

We should make sure to put this in the release notes for the next release.

@Gnuxie Gnuxie merged commit c61d883 into main Jan 19, 2022
Gnuxie added a commit that referenced this pull request Jul 1, 2022
We already made the mistake of using features from 16 without realising
Previously: #192
Gnuxie added a commit that referenced this pull request Jul 6, 2022
We already made the mistake of using features from 16 without realising
Previously: #192
Gnuxie added a commit that referenced this pull request Jul 6, 2022
* Bump minimum node version to 16.

We already made the mistake of using features from 16 without realising
Previously: #192

* Make sure CI uses specific version of node and we also lint.

https://github.com/matrix-org/pipelines/blob/master/mjolnir/pipeline.yml#L13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants