Since command: adding the ability to mute #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnuxie
reviewed
Apr 6, 2022
|
Could you also link to all of the issues that have requested or discussed muting in the PR (even if this PR is not addressing all of their concerns)? it'll help us figure out whether we're doing the right thing |
Open
Gnuxie
reviewed
Apr 8, 2022
Gnuxie
reviewed
Apr 8, 2022
src/commands/SinceCommand.ts
Outdated
| text: text_ | ||
|
|
||
| // Store list of affected users, in case we need it later. | ||
| /* no need to await */ mjolnir.client.sendStateEvent(targetRoomId, "org.matrix.mjolnir.since.mute", "", results); |
There was a problem hiding this comment.
if we are reusing joins to unmute users the same way they were muted, do we need the mute/unmute state events anymore? When I suggested this I was thinking unmute would use this state event when removing the power levels too, but that might not make sense now
There was a problem hiding this comment.
I think that we can avoid it for now and add the state event only later, if we realize we need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with some attacks.