Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A background queue for kicking #296

Merged
merged 7 commits into from
Jun 8, 2022
Merged

A background queue for kicking #296

merged 7 commits into from
Jun 8, 2022

Conversation

Yoric
Copy link
Contributor

@Yoric Yoric commented May 16, 2022

Is this the kind of thing you had in mind, @Gnuxie ?

@Yoric Yoric requested a review from Gnuxie May 16, 2022 10:36
src/queues/ThrottlingQueue.ts Outdated Show resolved Hide resolved
src/queues/ThrottlingQueue.ts Outdated Show resolved Hide resolved
src/queues/ThrottlingQueue.ts Show resolved Hide resolved
src/queues/ThrottlingQueue.ts Outdated Show resolved Hide resolved
test/integration/throttleQueueTest.ts Outdated Show resolved Hide resolved
src/commands/KickCommand.ts Outdated Show resolved Hide resolved
@Yoric Yoric requested a review from Gnuxie May 20, 2022 05:44
Copy link
Contributor

@Gnuxie Gnuxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I have two final nitpicks

src/queues/ThrottlingQueue.ts Outdated Show resolved Hide resolved
src/queues/ThrottlingQueue.ts Outdated Show resolved Hide resolved
@Yoric Yoric requested a review from Gnuxie May 24, 2022 15:19
@Yoric Yoric changed the title WIP: First draft of a background queue for kicking A background queue for kicking Jun 8, 2022
@Yoric Yoric merged commit 0eea04b into main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants