Refactor list creation with MSC3784 support. #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoric
approved these changes
Oct 19, 2022
| @@ -86,6 +86,10 @@ class PolicyList extends EventEmitter { | |||
| // Events that we have already informed the batcher about, that we haven't loaded from the room state yet. | |||
| private batchedEvents = new Set<string /* event id */>(); | |||
|
|
|||
| /** MSC3784 support. Please note that policy lists predate room types. So there will be lists in the wild without this type. */ | |||
| public static readonly ROOM_TYPE = "support.feline.policy.lists.msc.v1"; | |||
There was a problem hiding this comment.
support.feline.policy.lists.msc.v1? I assume that this was created for this occasion? We typically use org.matrix.mjolnir.XXX for Mjölnir-specific prefixes, no?
There was a problem hiding this comment.
This isn't my MSC, so we don't have a choice in the matter
There was a problem hiding this comment.
It's the unstable room type for MSC3784.
Edit: And I happen to be the author that picked the unstable identifier.
matrix-org/matrix-spec-proposals#3784 This was extracted from the appservice mjolnir work to reduce review burden.
Gnuxie
force-pushed
the
gnuxie/list-creation
branch
from
b4e4790
to
18d2f5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-spec-proposals#3784
This was extracted from the appservice mjolnir work to reduce review burden.
The idea behind supporting MSC3784 is that clients can start to provide UX for editing policy lists directly rather than going through Mjolinr commands.