Make autojoinOnlyIfManager true by default.
#451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoric
approved these changes
Dec 7, 2022
| @@ -127,7 +127,7 @@ const defaultConfig: IConfig = { | |||
| }, | |||
| dataPath: "/data/storage", | |||
| acceptInvitesFromSpace: '!noop:example.org', | |||
| autojoinOnlyIfManager: false, | |||
| autojoinOnlyIfManager: true, | |||
There was a problem hiding this comment.
Could you take the opportunity to document what autojoinOnlyIfManager does in IConfig?
Gnuxie
force-pushed
the
gnuxie/spaces-invite
branch
from
205f037
to
7ba6859
Compare
Also assert that we if `autojoinOnlyIfManager` is enabled that the user has provided a space for `acceptInvitesFromSpace`. It does sound like `autojoinOnlyIfManager` would imply that anyone could send an invitation to the mjolnir if `autojoinONlyIfManager` is false. This has never been the case though, and it is not sensible either, especially if `protectAllJoinedRooms` is also true. Additionally the documentation in `config/default.yaml` has always claimed that `autojoinOnlyIfManager` is "true by default". This setting has confused users in #mjolnir:matrix.org before Closes #436. Also fixes an issue in the appservice where we require `autojoinOnlyIfManager` to always be explicitly set to false or it crashes any Mjolnir receiving an invite.
Gnuxie
force-pushed
the
gnuxie/spaces-invite
branch
from
7ba6859
to
d7db362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also assert that we if
autojoinOnlyIfManageris enabled thatthe user has provided a space for
acceptInvitesFromSpace.It does sound like
autojoinOnlyIfManagerwould imply thatanyone could send an invitation to the mjolnir if
autojoinOnlyIfManageris false.This has never been the case though, and it is not sensible
either, especially if
protectAllJoinedRoomsis also true.Additionally the documentation in
config/default.yamlhas always claimed that
autojoinOnlyIfManageris "true by default".This setting has confused users in #mjolnir:matrix.org before
Closes #436.
Also fixes an issue in the appservice where we require
autojoinOnlyIfManagerto always be explicitly set to falseor it crashes any Mjolnir receiving an invite.