This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
sydent: Add support for matrix_is_tester #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
requested review from
a team,
anoadragon453,
babolivier,
erikjohnston and
richvdh
and removed request for
a team
richvdh
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Couple of questions.
nb. This is pinned to a different branch and should be updated to point to master once matrix-org/matrix-is-tester#5 is merged.
this is outdated?
be consistent re pip / python -m pip and don't set pythonpath unncesaarily
richvdh
approved these changes
Sep 6, 2019
|
Bleh, I wrote 4 words of a reply on this and then forgot about it for a week. But yes, we could fudge all the branches to get it running and then change them all across the various projects once we merge things - I'm not sure it's that worthwhile in this case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nb. This is pinned to a different branch and should be updated to point to master once matrix-org/matrix-is-tester#5 is merged.Now updated