Use thumbnails for big images #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow downloading of a thumbnail for a file. Note: Synapse really doesn't like it if you don't specify the height (I get a 500); so the caller has to give some guess of dimensions, but the server gives something reasonable. Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
When we decide from the image info that an image is too large, try a thumb instead. Pick 640x480 because a) we need to pick a size and b) That's the right size. c) We should make it configurable. (We could also try this if we didn't have the image info when we get the error). Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
|
great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the image size is too large (as indicated by the metadata in the event) use a thumbnail.