Create room #30
Closed
Create room #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works, however: When joining an existing room by alias, only the internal room name is listed at the top of the pidgin UI. A followup patch may be needed to grab the actual room name and display in pidgin. Signed-off-by: Damien Zammit <damien@zamaudio.com>
There is no hook in purple that allows to create a room separately from joining a room. In matrix there is a distinction. Therefore, try to join by either alias/id and if this fails, create the room. Currently this results in a disconnect but upon reconnecting you become a member of the new room. Signed-off-by: Damien Zammit <damien@zamaudio.com>
richvdh
requested changes
Jan 22, 2017
| @@ -54,6 +55,33 @@ static const char *matrixprpl_list_icon(PurpleAccount *acct, PurpleBuddy *buddy) | |||
| } | |||
|
|
|||
| /** | |||
| * Callback for when joining a room fails, create the room | |||
| */ | |||
| static void room_create_callback(MatrixConnectionData *conn, | |||
There was a problem hiding this comment.
Please could you find a better name for this - get_roomid_by_alias_failed_callback or something.
| } | ||
| errorstr = json_object_get_string_member(root_obj, "error"); | ||
| errcodestr = json_object_get_string_member(root_obj, "errcode"); | ||
| char roomid[strlen(errorstr) - 20]; |
There was a problem hiding this comment.
this is unportable. Please use malloc/free.
| errcodestr = json_object_get_string_member(root_obj, "errcode"); | ||
| char roomid[strlen(errorstr) - 20]; | ||
| if (errcodestr && !strcmp(errcodestr, "M_NOT_FOUND")) { | ||
| snprintf(roomid, strlen(errorstr) - 20, "%s", &errorstr[11]); |
There was a problem hiding this comment.
is this trying to fish the room alias out of the error string? what happens if the error string changes?
You should be able to get the alias from the user_data.
There was a problem hiding this comment.
Also, alias != id. Please don't call it roomid if it's not a room id.
| @@ -171,6 +171,13 @@ MatrixApiRequestData *matrix_api_sync(MatrixConnectionData *conn, | |||
| gpointer user_data); | |||
|
|
|||
|
|
|||
| MatrixApiRequestData *matrix_api_create_room(MatrixConnectionData *conn, | |||
| @@ -243,6 +250,13 @@ MatrixApiRequestData *matrix_api_join_room(MatrixConnectionData *conn, | |||
| gpointer user_data); | |||
|
|
|||
|
|
|||
| MatrixApiRequestData *matrix_api_room_set_public(MatrixConnectionData *conn, | |||
| @@ -865,6 +865,49 @@ void matrix_room_handle_timeline_event(PurpleConversation *conv, | |||
| g_free(escaped_body); | |||
| } | |||
|
|
|||
| /** | |||
| * Callback for after the room is created to tweak it to publically accessible | |||
There was a problem hiding this comment.
you should be able to do that in one step. set "visibility": "public" in the body of the createRoom request.
| if (errcodestr && !strcmp(errcodestr, "M_NOT_FOUND")) { | ||
| snprintf(roomid, strlen(errorstr) - 20, "%s", &errorstr[11]); | ||
| roomid[strlen(errorstr) - 20] = '\0'; | ||
| room_alias = g_strdup(roomid); |
There was a problem hiding this comment.
Where is this freed? (And why is taking a copy necessary anyway?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate PR but requires the previous one as it builds upon join room. Addresses issue #26