Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that decryption is supported #90

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

aaronraimist
Copy link
Contributor

@aaronraimist aaronraimist commented Jan 28, 2019

Signed-off-by: Aaron Raimist aaron@raim.ist

README isn't very clear that decryption is supported but encryption is not. Got reports that someone was able to decrypt messages in pidgin and thought everyone thought that encryption was broken for a second. https://matrix.to/#/!iNmaIQExDMeqdITdHH:matrix.org/$15487094581170217pdtaL:matrix.org?via=matrix.org&via=linuxgaming.life&via=disroot.org

README isn't very clear that decryption is supported but encryption is not. Got reports that someone was able to decrypt messages in pidgin and thought everyone thought that encryption was broken for a second. https://matrix.to/#/!iNmaIQExDMeqdITdHH:matrix.org/$15487094581170217pdtaL:matrix.org?via=matrix.org&via=linuxgaming.life&via=disroot.org
@richvdh richvdh merged commit ab757f6 into matrix-org:master Jan 29, 2019
@steils
Copy link
Contributor

steils commented Jan 30, 2019

Hi! Does decryption really work for you? I still get this: #85
(and haven't had time to debug it unfortunately)

@aaronraimist aaronraimist deleted the patch-1 branch January 30, 2019 00:05
@aaronraimist
Copy link
Contributor Author

aaronraimist commented Jan 30, 2019

I haven't used purple-matrix but I've seen it work. Yesterday it was reported that someone was able to decrypt messages in Pidgin. They didn't know it supported decryption at all so they thought something was broken which is why I made this PR.

pidgin_chat
screen shot 2019-01-29 at 6 08 03 pm

@schildbach
Copy link

In rooms with encryption enabled, pidgin/libpurple is the only client which doesn't get the messages. So I assume it doesn't support encryption.

It can send messages into an encrypted room, though they are then plaintext (as indicated by the other clients).

@richvdh
Copy link
Member

richvdh commented Jan 30, 2019

In rooms with encryption enabled, pidgin/libpurple is the only client which doesn't get the messages.

decryption is supported since #70 landed. If it's not working for you, that's a separate problem. Possibly you have built it without it enabled. Either way, it's not a matter for this PR.

So I assume it doesn't support encryption.

This is true, but your line of reasoning to get to it is faulty.

@schildbach
Copy link

@richvdh You're likely right. I'm using a version from before Aug 2018. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants