Initial attempt at a generic webhook for reports. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background submission to a notification server that doesn't block rageshake submission.
|
I'm unsure what the WriteTo error in linting is about at the moment; I haven't adjusted that method or changed calls to it (as far as I'm aware). |
Ah, ignore me (ish). Locally, scripts/lint.sh is reporting: From the go vet incantation But the actual error in CI is coming from gocyclo complaining that main.go is at 13 now, not sure why go vet isn't reporting/running in CI the same as locally. |
|
If 8e00140 is a reasonable pattern, i could replicate for the other config handling sections |
michaelkaye
force-pushed
the
michaelk/proxy_rageshake_requests
branch
from
721f119
to
4e3eeec
Compare
richvdh
approved these changes
Feb 1, 2022
submit.go
Outdated
Comment on lines
525
to
531
| // Enrich the parsedPayload with a reportURL and listingURL, to convert a single struct | ||
| // to JSON easily | ||
| genericHookPayload := genericWebhookPayload{ | ||
| parsedPayload: p, | ||
| ReportURL: reportURL, | ||
| ListingURL: listingURL, | ||
| } |
There was a problem hiding this comment.
hoist outside the loop, since it's independent?
(But keep making bytes.Buffer multiple times as these is read from by each http request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background submission to a notification server that doesn't block rageshake submission.
Timeout requests after 300s (to provide some wiggle room for servers that choose to take action inline)
Add docs on the format of the endpoint (though much of it is pass-through so there is no fixed schema in most cases)