No container tags corresponding to version releases

[spantaleev]

It looks like there's no v1.8 (or 1.8) container image tag published to the ghcr.io/matrix-org/rageshake container registry.

It's just master, etc., which is a moving target and dangerous to use.

[richvdh]

Looks like https://github.com/matrix-org/rageshake/blob/master/.github/workflows/docker.yaml needs updating to run on tag events

[t3chguy]

@richvdh why tag over release ooi?

[richvdh]

If you get GHA notifications for releases then yes, that would work well too

[t3chguy]

Its what we use in the web app team's automations, means you can draft releases without them getting deployed until they're published - https://github.com/matrix-org/matrix-js-sdk/blob/develop/.github/workflows/release.yml

[michaelkaye]

I think it's not even as complicated as that:

Warning: v1.8 is not a valid semver. More info: https://semver.org/
Warning: v1.8 is not a valid semver. More info: https://semver.org/
Warning: v1.8 is not a valid semver. More info: https://semver.org/

I think it's actually fine; we just need to be "more semver" rather than just versioned.

0f14dc8 is the commit that (would) trigger the build of the tag
https://github.com/matrix-org/rageshake/actions/runs/3913755336/jobs/6690023916 is the run that ran, but it didn't label anything because semver.

[michaelkaye]

https://github.com/michaelkaye/rageshake - yeah, i tried to release a v2.0.0 of rageshakes on this fork and the right thing happened with the docker build. I think we could avoid fighting the system and say we'll move to semver versions. Which looks like it's actually the reason behind #51