Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix save ratio check #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix save ratio check #90

wants to merge 1 commit into from

Conversation

Fizzadar
Copy link

@Fizzadar Fizzadar commented Jun 2, 2022

Currently the compressor will rewrite state even if the result consists
of the same number of rows which doesn't match the log statement.

@Fizzadar
Fix save ratio check
dc1caa7 
Currently the compressor will rewrite state even if the result consists
of the same number of rows which doesn't match the log statement.
@Fizzadar Fizzadar requested a review from a team as a code owner June 2, 2022 17:09
@erikjohnston
Copy link
Member

erikjohnston commented Jun 6, 2022 •
edited
Loading

The clippy lint will be fixed by #92 #91

The test failure is annoying, as it looks like the test cases that we're using ends up generating the same number of rows?

@clokep
Copy link

clokep commented Jun 7, 2022

I think this is waiting on @Fizzadar, so I'm going to remove this from the review queue.

@clokep clokep removed the request for review from a team June 7, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fizzadar @erikjohnston @clokep