Merge pull request #296 from matrix-org/babolivier/return_raise

Raise IncorrectSessionTokenException instead of returning it
matrix-org · May 28, 2020 · a005037 · a005037
2 parents 6453fcb + 0a90ad4
commit a005037
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/296.bugfix b/changelog.d/296.bugfix
@@ -0,0 +1 @@
+Fix a bug in the error handling of 3PID session validation, if the token submitted is incorrect.
diff --git a/sydent/validators/common.py b/sydent/validators/common.py
@@ -64,4 +64,4 @@ def validateSessionWithToken(sydent, sid, clientSecret, token):
         return {'success': True}
     else:
         logger.info("Incorrect token submitted")
-        return IncorrectSessionTokenException()
+        raise IncorrectSessionTokenException()