Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling federation.verifycerts breaks federation requests #145

Closed
erikjohnston opened this issue Apr 26, 2019 · 3 comments
Closed

Enabling federation.verifycerts breaks federation requests #145

erikjohnston opened this issue Apr 26, 2019 · 3 comments
Labels
Synapse v1.0 T-Defect

Comments

@erikjohnston
Copy link
Member

Attempts at outbound federation when enabled results in:

ValueError: Specify client CA certificate information if and only if enabling certificate verification

This is due to setting CertificateOptions incorrectly at:

sydent/sydent/http/federation_tls_options.py

Line 93 in 4389c21

self._options = ssl.CertificateOptions(verify=config.getboolean("http", "federation.verifycerts"))

as twisted require if verify=True that you also specify CAs.
@erikjohnston
Copy link
Member Author

Broke in af2db70 from #133

@erikjohnston
Copy link
Member Author

Looks like the fix here is to use the trustRoot parameter instead with OpenSSLDefaultPaths?

@neilisfragile neilisfragile mentioned this issue Apr 26, 2019
Closed
@anoadragon453
Copy link
Member

Can this be closed now that #147 has been merged?

@richvdh richvdh closed this as completed May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Synapse v1.0 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neilisfragile @anoadragon453 @richvdh @erikjohnston