Federation requests use deprecated code & get host header wrong

[dbkr]

Federation requests now use new code from synapse to do the requests properly with .well-known lookups, but they also still call the old, simplistic implementation:

sydent/sydent/threepid/bind.py

Line 104 in bb346c4

server = yield self._pickServer(domain)

This means the old impl replaces the domain with a server from an SRV lookup which means the new code can't do its job properly.

Looks like the call to _pickServer and all that code should just be removed and domain put straight into the URL, and 'https' replaced with 'matrix', and then it should work.

Practically, this is causing invites not to turn up on matrix.org (and oresumably any other servers with similar setup) because the onbind requests don't go through.

[richvdh]

this appears to have been fixed by #185