Fix federation lookups in onbind callbacks #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was doing an extra pickServer before attempting to hit the matrix URL, so effectively doing the srv lookup twice, which makes it not work. This removes all the unnecessary code and makes it work. Fixes element-hq/element-web#10483
anoadragon453
approved these changes
Aug 5, 2019
|
thanks! yep, tested locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was doing an extra pickServer before attempting to hit the
matrix URL, so effectively doing the srv lookup twice, which makes
it not work. This removes all the unnecessary code and makes it work.
CI failing because, well, because there isn't any, but I created the buildkite pipeline so the CI runs on the branch which has CI.
Fixes element-hq/element-web#10483