Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /_matrix/identity/api/v1/validate/email/requestToken returns "success" key #195

Open
anoadragon453 opened this issue Aug 20, 2019 · 2 comments

Comments

@anoadragon453
Copy link
Member

POST /_matrix/identity/api/v1/validate/email/requestToken returns a success key, which is not defined in the spec.

{
  "success": true,
  "sid": "702675865"
}
@bmarty
Copy link

bmarty commented May 9, 2020

I still observe that today. Clients should ignore the success key, right?

bmarty added a commit to element-hq/element-android that referenced this issue May 10, 2020
@anoadragon453
Copy link
Member Author

I still observe that today. Clients should ignore the success key, right?

Correct, seeing as Sydent will never return "success": false anyways :)

if not resp:
resp = {'success': True, 'sid': str(sid)}
return resp

bmarty added a commit to element-hq/element-android that referenced this issue May 11, 2020
bmarty added a commit to element-hq/element-android that referenced this issue May 13, 2020
bmarty added a commit to element-hq/element-android that referenced this issue May 18, 2020
bmarty added a commit to element-hq/element-android that referenced this issue May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants