Fix confused handling of replication ports in the DB #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's niche, but if no replication base url was configured and a peer was configured with a NULL port in the db, then we would try to format None as an integer and get a TypeError for our troubles. Spotted by work in progress elsewhere to make Sydent pass mypy --strict. Fixes #419.
DMRobertson
changed the title
clokep
suggested changes
Oct 12, 2021
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
I wonder if mypy would have spotted this---surprised flake8 didn't!
clokep
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's niche, but if no replication base url was configured and a peer was
configured with a NULL port in the db, then we would try to format None
as an integer and get a TypeError for our troubles.
Equally, if we did specify a port in the DB and did provide a replication URL, the db's port would be ignored---except for logging, which would happily report the wrong port.
Spotted by work in progress elsewhere to make Sydent pass mypy --strict.
Fixes #419.