Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confused handling of replication ports in the DB #420

Merged
merged 4 commits into from Oct 12, 2021

Commits on Oct 11, 2021

  1. Fix TypeError when peers.port contains nulls

    It's niche, but if no replication base url was configured and a peer was
    configured with a NULL port in the db, then we would try to format None
    as an integer and get a TypeError for our troubles.
    
    Spotted by work in progress elsewhere to make Sydent pass mypy --strict.
    
    Fixes #419.
    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    69af0fc View commit details
    Browse the repository at this point in the history
  2. Changelog

    David Robertson committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    7b32ecf View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Update sydent/replication/peer.py

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    David Robertson and clokep committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    e6e1791 View commit details
    Browse the repository at this point in the history
  2. Fix logger grrrrr

    I wonder if mypy would have spotted this---surprised flake8 didn't!
    David Robertson committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    651432b View commit details
    Browse the repository at this point in the history