send_attempt is an int in msisdn too

[DMRobertson]

Like #460 and #461, but for phone numbers.

[DMRobertson]

Oh, I need to rebase onto main and also add a changelog.

[clokep]

Code looks fine, although linting is failing!

[DMRobertson]

Code looks fine, although linting is failing!

Yeah. I think something going wrong with mocking an async function on 3.6 (works fine locally on 3.9). I'll investigate.

[babolivier]

Yeah. I think something going wrong with mocking an async function on 3.6 (works fine locally on 3.9). I'll investigate.

Yeah awaiting on a Mock doesn't work on 3.6. In Synapse, we have make_awaitable to cover that: https://github.com/matrix-org/synapse/blob/bfb4b858a999684ba2459ee4c3aa20270d13062d/tests/test_utils/__init__.py#L49-L57 (so if your mock's return_value is "foo" you replace it with make_awaitable("foo").

Not sure why it's only an issue with sydent now, but I'd say that's probably the way to go?

[DMRobertson]

Yeah awaiting on a Mock doesn't work on 3.6. In Synapse, we have make_awaitable to cover that:

Thanks, that does the trick.

Not sure why it's only an issue with sydent now, but I'd say that's probably the way to go?

Probably because we've never tried to mock an async function in Sydent before.