Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PII logging from log-level INFO #208

Closed
wants to merge 1 commit into from
Closed

Remove PII logging from log-level INFO #208

wants to merge 1 commit into from

Conversation

anoadragon453
Copy link
Member

Fixes #190

Remove unnecessary PII logging and moves any necessary bits for debugging to the debug log level.

Also fixes a couple minor nits found.

@anoadragon453 anoadragon453 requested a review from a team September 3, 2019 17:01
@anoadragon453 anoadragon453 changed the title Remove PII logging from info Remove PII logging from log-level INFO Sep 3, 2019
richvdh
richvdh reviewed Sep 4, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we decided that PII in logs was ok as long as the logs got rotated?

@anoadragon453
Copy link
Member Author

I think we have. I was unsure whether we still wanted to move things to debug just-in-case.

But there's probably not much point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh left review comments

Assignees
No one assigned
Labels
phase:1 privacy-sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anoadragon453 @richvdh