Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templates to be valid python format strings #377

Merged
merged 2 commits into from Aug 10, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 10, 2021

Subset of #375

Pull Request Checklist

  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fix a bug that prevented receiving messages from other servers." instead of "Move X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off

@babolivier babolivier requested a review from a team August 10, 2021 08:49
@babolivier babolivier merged commit 779db24 into matrix-org:main Aug 10, 2021
@@ -0,0 +1 @@
Fix email templates to be valid python format strings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been a bugfix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presumed the files were to be treated as sample templates rather than the canonical ones, so didn't consider a broken example to be a "bug"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fair. I'm not sure if we're really clear at how one is to deploy sydent since... it isn't widely deployed beyond us. Carry on! 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it isn't widely deployed beyond us

For what it's worth, I think this is increasingly untrue - despite the fact that the deployment process is undocumented and fraught with footguns (#131 is particularly relevant here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants