Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run mypy in CI on the sydent package #416

Merged
merged 7 commits into from Oct 14, 2021
Merged

Run mypy in CI on the sydent package #416

merged 7 commits into from Oct 14, 2021

Conversation

DMRobertson
Copy link
Contributor

No description provided.

@DMRobertson
Copy link
Contributor Author

Sadly, mypy is failing. I propose that we fix that up in forthcoming PRs

@DMRobertson DMRobertson requested a review from a team October 8, 2021 18:15
@DMRobertson DMRobertson mentioned this pull request Oct 8, 2021
Merged
@clokep
Copy link
Contributor

clokep commented Oct 8, 2021

This seems to not be passing mypy checks.

Try marking mypy as continue-on-error
d05b733 
Until mypy is passing there's no point showing scary red warning X
symbols for failed builds.
@DMRobertson
Copy link
Contributor Author

Hmm. I'm not sure I'm happy with d05b733. I wanted it to produce a green tick against a particular commit (done), but not to report "all checks have passed" in the review summary.

@DMRobertson DMRobertson mentioned this pull request Oct 11, 2021
Merged
@erikjohnston
Copy link
Member

I think the decision here was to change it so that we did mypy checks only on specific files we know pass.

@erikjohnston erikjohnston removed the request for review from a team October 13, 2021 09:34
@erikjohnston erikjohnston marked this pull request as draft October 13, 2021 09:34
@DMRobertson DMRobertson marked this pull request as ready for review October 14, 2021 11:04
@DMRobertson DMRobertson requested a review from a team October 14, 2021 11:04
@DMRobertson DMRobertson merged commit 85e8397 into main Oct 14, 2021
@DMRobertson DMRobertson deleted the dmr/mypy-ci branch October 14, 2021 11:14
@DMRobertson DMRobertson mentioned this pull request Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DMRobertson @clokep @erikjohnston