Whitelist webpush endpoints #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
force-pushed
the
bwindels/whitelist-webpush-endpoints
branch
from
56f6114
to
1f55017
Compare
|
Does it make sense to include some info on Google/Microsoft/Mozilla here so people know what a reasonable value is? |
bwindels
force-pushed
the
bwindels/whitelist-webpush-endpoints
branch
from
ed3b438
to
329f3aa
Compare
Added this to the docs 👍 |
|
How would I fix this error?: |
bwindels
force-pushed
the
bwindels/whitelist-webpush-endpoints
branch
from
d8c69b0
to
a8765c1
Compare
When you define self.foo = None # type: Optional[List[str]]
if blah:
self.foo = list(...)You'll also need a |
clokep
reviewed
Mar 22, 2021
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
through an optional
allowed_endpointsconfiguration keyI added support for globs because some browser vendor endpoints seem to contain sharding identifiers in the subdomain.