Improve static type checking #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type annotation to json_encode Function on apnstruncate.py file fixes #201 Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
babolivier
suggested changes
Apr 29, 2021
There was a problem hiding this comment.
Thanks a lot for your contribution, there's one small change to make but overall it looks good to me :)
I'm also going to edit the PR description so it doesn't accidentally close #201 (since this is only addressing part of the issue).
Add type annotation to json_encode Function on apnstruncate.py file fixes #201 Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
babolivier
approved these changes
Apr 30, 2021
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type annotation to
json_encode Functiononapnstruncate.pyfile