Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve static type checking #227

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Improve static type checking #227

merged 3 commits into from
Jun 7, 2021

Conversation

kibablu
Copy link
Contributor

@kibablu kibablu commented Jun 1, 2021

Add type annotation to truncate Function on apnstruncate.py file
as part of the #201 issue

Add type annotation to truncate Function on apnstruncate.py file
as part of #201 issue

Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from one small tweak requested

sygnal/apnstruncate.py Outdated Show resolved Hide resolved
Part of #201 issue

Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
@callahad
Copy link
Contributor

callahad commented Jun 7, 2021

🎉 Thank you so much!

@callahad callahad merged commit 4f4d7ce into matrix-org:main Jun 7, 2021
@kibablu kibablu deleted the truncateFunction branch June 8, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants