Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check newsfile more carefully (correct number, correct punctuation) #250

Merged
merged 9 commits into from
Aug 10, 2021

Conversation

reivilibre
Copy link
Contributor

This heavily borrows from Synapse.

Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Copy link
Contributor Author

The CI runs above demonstrate what you see when you make a mistake.

@reivilibre reivilibre requested a review from a team August 10, 2021 10:34
anoadragon453
anoadragon453 previously approved these changes Aug 10, 2021
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

scripts-dev/check_newsfragment.sh Outdated Show resolved Hide resolved
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@reivilibre reivilibre merged commit 9dabdbd into main Aug 10, 2021
@reivilibre reivilibre deleted the rei/check_newsfile_number branch August 10, 2021 11:44
reivilibre added a commit that referenced this pull request Aug 10, 2021
…250)

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants