Treat more APNs errors as permanent rejections #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squahtx
commented
Dec 2, 2021
squahtx
commented
Dec 2, 2021
clokep
reviewed
Dec 3, 2021
clokep
reviewed
Dec 3, 2021
Comment on lines
+90
to
+91
| (400, "DeviceTokenNotForTopic"), | ||
| (400, "TopicDisallowed"), |
There was a problem hiding this comment.
Do both of these mean a broken client?
There was a problem hiding this comment.
I think both of these mean a developer has messed up in some way. I'm not 100% clear on the how. I think the former means the token is valid but for a different app ID and the latter seems to be something to do with mixing up VOIP and non-VOIP tokens/topics.
There was a problem hiding this comment.
Alright! Thanks for the explanation!
clokep
reviewed
Dec 6, 2021
clokep
approved these changes
Dec 6, 2021
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279