Update aioapns dependency to one that supports python 3.10+ #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Just to convince myself this was safe, it seems that we really need >= 2.1 to support Python 3.10.
Bumping to 3.0 itself is probably fine though.
|
@bradtgmurray Thanks! I just realized you didn't sign-off on these changes, would you mind adding your sign-off when you get a moment? |
The description was updated, so we're all set. 👍 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe apns support has been broken since #343, see comment #343 (comment)
This brings us to the latest version of aioapns and fixes it to work on newer version of Python.
Signed-off-by: Brad Murray brad@beeper.com