Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log level for "/health" endpoint to debug #352

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Change log level for "/health" endpoint to debug #352

merged 2 commits into from
Oct 10, 2023

Conversation

dklimpel
Copy link
Contributor

Closes #351

Similar to matrix-org/synapse#8048
Healtch checks should not spam the log file.

Logs /health in DEBUG instead INFO log.

@dklimpel dklimpel marked this pull request as ready for review October 10, 2023 06:21
@dklimpel dklimpel requested a review from a team as a code owner October 10, 2023 06:21
DMRobertson
DMRobertson reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Can you sign-off, please?

@dklimpel
Copy link
Contributor Author

Signed-off-by: Dirk Klimpel 5740567+dklimpel@users.noreply.github.com

DMRobertson
DMRobertson approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DMRobertson DMRobertson merged commit b83661c into matrix-org:main Oct 10, 2023
5 checks passed
@dklimpel dklimpel deleted the update_logging branch October 10, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable logging for health endpoint
2 participants
@dklimpel @DMRobertson