This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Move to storing state_groups_state as deltas #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/state_storage
branch
2 times, most recently
from
5b5fb8b
to
1d1a984
Compare
erikjohnston
force-pushed
the
erikj/state_storage
branch
from
1d1a984
to
a99e933
Compare
| # txn.executemany( | ||
| # "DELETE FROM state_groups WHERE id = ?", | ||
| # state_rows | ||
| # ) |
There was a problem hiding this comment.
While I do usually approve of comments, I'm not so sure about these ones.
There was a problem hiding this comment.
Maybe replace this with some kind of TODO:...
|
LGTM appart from the commented out code |
|
Maybe explain why we can use WITH Recursive on postgres but not on sqlite? |
| prev_state = self._get_state_groups_from_groups_txn( | ||
| txn, [prev_group], types=None | ||
| ) | ||
| prev_state = prev_state.values()[0] |
There was a problem hiding this comment.
Why not prev_state[prev_group]?
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.