Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

/send_join response includes unstable prefix for event field #11345

Closed
clokep opened this issue Nov 15, 2021 · 3 comments · Fixed by #11413 or #12395
Closed

/send_join response includes unstable prefix for event field #11345

clokep opened this issue Nov 15, 2021 · 3 comments · Fixed by #11413 or #12395
Assignees
@clokep
Labels
A-Spaces Hierarchical organization of rooms T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Contributor

clokep commented Nov 15, 2021

The response generated for /send_join (and parsing of it on the federation client side) still uses an unstable prefix from MSC3083: org.matrix.msc3083.v2.event.

This should be updated to be just event, the stable field name. We probably need to send / handle both for a period of time unfortunately.

See

synapse/synapse/federation/federation_server.py

Line 617 in 98c8fc6

"org.matrix.msc3083.v2.event": event.get_pdu_json(),

@clokep clokep self-assigned this Nov 15, 2021
@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 15, 2021
@clokep clokep mentioned this issue Nov 23, 2021
Merged
@clokep
Copy link
Contributor Author

clokep commented Nov 29, 2021

This should not have been closed -- #11413 added the stable field but did not remove the unstable field.

@clokep clokep reopened this Nov 29, 2021
@clokep clokep added the A-Spaces Hierarchical organization of rooms label Jan 14, 2022
@clokep
Copy link
Contributor Author

clokep commented Mar 10, 2022

Note that the proper field landed in Synapse v1.49.0, release 2021-12-21.

@clokep
Copy link
Contributor Author

clokep commented Apr 6, 2022

Note that Synapse v1.41.0 had support for room version 8, and Synapse v1.42.0 had support for room version 9; both of which could use the fields from above.

@clokep clokep mentioned this issue Apr 6, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Spaces Hierarchical organization of rooms T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
1 participant
@clokep