Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Expose whether a room is a space in the Admin API #11904

Closed
anoadragon453 opened this issue Feb 3, 2022 · 6 comments
Closed

Expose whether a room is a space in the Admin API #11904

anoadragon453 opened this issue Feb 3, 2022 · 6 comments
Labels
good first issue Good for newcomers T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@anoadragon453
Copy link
Member

Currently there is no way to tell whether a given room is a space or not through Synapse's Admin API.

Ideally, this would be exposed in both the List Room and Room Details APIs.

I suggest to expose a type property which returns the room type. The type would mirror the room's m.room.create event's content.type property. For a space, as specified by MSC1772 as m.space.

@anoadragon453 anoadragon453 added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Feb 3, 2022
@clokep clokep added the good first issue Good for newcomers label Feb 3, 2022
@lukasdenk
Copy link
Contributor

Ok, I'll work on it :)

@dklimpel
Copy link
Contributor

dklimpel commented Feb 8, 2022

I am not sure if the information (room vs. space) perhaps should become a attribut/column in room_stats_state or rooms table instead read it every time from the m.room.create event.

@arneja-arnav
Copy link

Is this issue still open? I'd like to work on it as well.

@dklimpel
Copy link
Contributor

Yes, it is still open: #11934 (comment)

@andrewdoh
Copy link
Contributor

andrewdoh commented Jul 7, 2022

hi I've made the changes. could someone please check this out: #13208

@anoadragon453
Copy link
Member Author

anoadragon453 commented Nov 16, 2022

Looks like this was indeed done in #13208 :) Thanks @andrewdoh!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants