Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: various FIXMEs and races #12646

Closed
richvdh opened this issue May 5, 2022 · 1 comment
Closed

Faster joins: various FIXMEs and races #12646

richvdh opened this issue May 5, 2022 · 1 comment
Labels
A-Federated-Join joins over federation generally suck T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Milestone
Q2 2022 ─ Faster ...

Comments

@richvdh
Copy link
Member

richvdh commented May 5, 2022

The current implementation is littered with FIXME comments. We'll need to go through and fix them.

(one example: correctly handle a second /join request while the first one is still syncing up. Currently this will explode in a heap.)
@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label May 5, 2022
@MadLittleMods MadLittleMods mentioned this issue May 18, 2022
Merged
@MadLittleMods MadLittleMods mentioned this issue May 23, 2022
Closed
@MadLittleMods MadLittleMods added the A-Federated-Join joins over federation generally suck label Jun 3, 2022
This was referenced Jun 9, 2022
Closed
Closed
Closed
@richvdh
Copy link
Member Author

richvdh commented Jun 9, 2022

closing this in favour of more specific issues

@richvdh richvdh closed this as completed Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federated-Join joins over federation generally suck T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
Q2 2022 ─ Faster joins phase 2: corre...
Development

No branches or pull requests
4 participants
@MadLittleMods @anoadragon453 @richvdh @squahtx