Fix bug /sync returning 404 #12729
Fix bug /sync returning 404 #12729
Conversation
|
I think the test failure is due to this not being up to date with develop? |
erikjohnston
added
the
X-Release-Blocker
It looks like we would need #12683. Do we want to include that in the release branch too? |
| WHERE room_id = ? | ||
| AND stream_ordering <= ? | ||
| AND NOT outlier | ||
| AND rejections.reason IS NULL |
There was a problem hiding this comment.
I'm having trouble understanding how #12319 broke things. The previous code did a get_recent_events_for_room, which looks like it doesn't check for rejection either?
There was a problem hiding this comment.
Oh, hmm, you're right. The PR did make it worse though as the query actually doubles the specified limit (to take account of filtering), so before we'd have to have two rejected events next to each other to hit the bug
I'd rather not put more into this release if we can help it. I can live with complement failing that one test for now |
Co-authored-by: David Robertson <davidr@element.io>
|
Complement failure is expected, see above. |
Synapse 1.59.0rc2 (2022-05-16) ============================== Synapse 1.59 makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](#12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](#12452), [\#12654](#12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](#12597)) Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0 where `/sync` would fail if the most recent event in a room was rejected. ([\#12729](#12729))
I've based this on v1.59 branch, I think its worth sneaking this fix into v1.59.0
Fixes #12571