Synapse supports unspecced DELETE /directory/list/room/<room ID> endpoint

[DMRobertson]

Synapse supports a DELETE /directory/list/room/<room ID> endpoint which appears to be unspecced. (It's specced with GET and PUT).

synapse/synapse/rest/client/directory.py

Lines 157 to 166 in e24ff8e

	async def on_DELETE(
	self, request: SynapseRequest, room_id: str
	) -> Tuple[int, JsonDict]:
	requester = await self.auth.get_user_by_req(request)
	await self.directory_handler.edit_published_room_list(
	requester, room_id, "private"
	)
	return 200, {}

Originally posted by @DMRobertson in #13102 (comment)

DELETE is a shortcut for PUTting private visibility. I'd like to either spec it or remove it.

[santhoshivan23]

@DMRobertson The right place to spec it is in matrix-spec repo right? I think its better to spec it. What say?

[clokep]

Part of #8334.

[richvdh]

I think its better to spec it

I don't like having more than one way to do something: it leads to incompatible implementations. If you can do the equivalent with PUT, better to remove DELETE.

[DMRobertson]

I don't like having more than one way to do something: it leads to incompatible implementations. If you can do the equivalent with PUT, better to remove DELETE.

Agreed entirely. What I should have said above: we should check to see if any clients use this (i.e. if matrix.org has seen a significant number of requests to this endpoint with method DELETE). I hope not, so we can rip this out.

[richvdh]

element-web uses PUT. No DELETE requests to matrix.org in the past week. Let's rip it out.

[DMRobertson]

There is also an unspecced DELETE on the application-service version of this endpoint.