Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Users who register through GitHub cannot bind their email #14326

Open
MomentQYC opened this issue Oct 29, 2022 · 3 comments
Open

Users who register through GitHub cannot bind their email #14326

MomentQYC opened this issue Oct 29, 2022 · 3 comments
Labels
A-3PID 3rd party identifiers: e.g. email, phone number A-SSO Single Sign-On (maybe OIDC) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@MomentQYC
Copy link
Contributor

Description

When a user signs up through GitHub, the user cannot bind their email address and cannot back up the encryption keys.
It shows
image
But if you are a registered user via email, it's perfectly normal to do all this.

Steps to reproduce

  • Register via Github
  • Bind a email address or backup the encryption keys

Homeserver

hashi.sbs

Synapse Version

Synapse 1.70.1

Installation Method

Debian packages from packages.matrix.org

Platform

Ubuntu 20.04.5
Python 3.8

Relevant log output

No log

Anything else that would be useful to know?

Related config file snippets

enable_registration_without_verification: false
registrations_require_3pid:
  - email

oidc_providers:
  - idp_id: github
    idp_name: Github
    idp_brand: "github"  # optional: styling hint for clients
    discover: false
    issuer: "https://github.com/"
    client_id: "***" # TO BE FILLED
    client_secret: "***" # TO BE FILLED
    authorization_endpoint: "https://github.com/login/oauth/authorize"
    token_endpoint: "https://github.com/login/oauth/access_token"
    userinfo_endpoint: "https://api.github.com/user"
    scopes: ["read:user"]
    user_mapping_provider:
      config:
        subject_claim: "id"
        localpart_template: "{{ user.login }}"
        display_name_template: "{{ user.name }}"
    
enable_3pid_changes: true

Re-login did not solve the problem.

@MomentQYC
Copy link
Contributor Author

This seems to be a logic issue. The user is logged in on the app, yet opens the link in the browser (not logged in) and then verifies through GitHub, but since the browser is not actually logged in, there is this problem?
This is just a guess on my part, I hope it helps.

@DMRobertson DMRobertson added A-SSO Single Sign-On (maybe OIDC) A-3PID 3rd party identifiers: e.g. email, phone number S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 31, 2022
@DMRobertson
Copy link
Contributor

The user is logged in on the app, yet opens the link in the browser (not logged in) and then verifies through GitHub, but since the browser is not actually logged in, there is this problem?

This seems to match the text of the warning message itself:

make sure you [...] open the validation link in the same client you're logging in from.

Which client are you using?

@DMRobertson DMRobertson added the X-Needs-Info This issue is blocked awaiting information from the reporter label Oct 31, 2022
@MomentQYC
Copy link
Contributor Author

MomentQYC commented Nov 1, 2022

The user is logged in on the app, yet opens the link in the browser (not logged in) and then verifies through GitHub, but since the browser is not actually logged in, there is this problem?

This seems to match the text of the warning message itself:

make sure you [...] open the validation link in the same client you're logging in from.

Which client are you using?

Element Desktop 1.11.12(Windows 11)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-3PID 3rd party identifiers: e.g. email, phone number A-SSO Single Sign-On (maybe OIDC) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

2 participants