"db_to_json" storage method is poorly named

[anoadragon453]

This method converts a JSON-encoded string from a database into a Python dictionary object.

synapse/synapse/storage/_base.py

Lines 146 to 170 in a466164

	def db_to_json(db_content: Union[memoryview, bytes, bytearray, str]) -> Any:
	"""
	Take some data from a database row and return a JSON-decoded object.
	Args:
	db_content: The JSON-encoded contents from the database.
	Returns:
	The object decoded from JSON.
	"""
	# psycopg2 on Python 3 returns memoryview objects, which we need to
	# cast to bytes to decode
	if isinstance(db_content, memoryview):
	db_content = db_content.tobytes()
	# Decode it to a Unicode string before feeding it to the JSON decoder, since
	# it only supports handling strings
	if isinstance(db_content, (bytes, bytearray)):
	db_content = db_content.decode("utf8")
	try:
	return json_decoder.decode(db_content)
	except Exception:
	logging.warning("Tried to decode '%r' as JSON and failed", db_content)
	raise

db_to_json feels like the wrong name for it. Perhaps deserialise_json_from_db?

[clokep]

This method converts a JSON-encoded string from a database into a Python dictionary.

It isn't always dictionaries, it can be anything that can be JSON encoded.