Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improved confirm_localpart #14790

Open
gabrc52 opened this issue Jan 9, 2023 · 0 comments
Open

Improved confirm_localpart #14790

gabrc52 opened this issue Jan 9, 2023 · 0 comments
Labels
A-SSO Single Sign-On (maybe OIDC) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@gabrc52
Copy link
Contributor

gabrc52 commented Jan 9, 2023

Description:

For OIDC, you can enable the confirm_localpart option so people can confirm their username.

But sometimes, for instance, you want users to be able to change their display name but not their email address, maybe also not their localpart either.

A drawback of this option is that it is only available for OIDC and not for SAML for instance (unsure if it's there for CAS). So, this feature request is 2 things:

(1) Make what specific user attributes have to be confirmed on signup more configurable
(2) Make this feature available for anyone using SSO, and not just OIDC people

I have never contributed to Synapse before, but I'm willing to try my shot at making a PR for this.

Edit: Other related improvements

I do want to send a PR. I plan to submit PR 1 and 2 first since they're most straightforward, then a separate draft PR for 3, and finally 4.

  1. Make confirm_localpart available to SAML and CAS too (this issue)

  2. Make the name and icon customizable for SAML and CAS

  3. Make changing/confirming email, localpart and display name independent from each other and each customizable from the homeserver config. (confirm_localpart should still be there for backwards compatibility purposes)

  4. Let people define custom properties users can confirm or specify when signing up (using a custom template), and pass them to on_user_registration.

@DMRobertson DMRobertson added A-SSO Single Sign-On (maybe OIDC) S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-SSO Single Sign-On (maybe OIDC) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants