Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

/invite fails with a 500 error if target MXID is invalid (SYN-664) #1521

Closed
matrixbot opened this issue Mar 25, 2016 · 5 comments
Closed

/invite fails with a 500 error if target MXID is invalid (SYN-664) #1521

matrixbot opened this issue Mar 25, 2016 · 5 comments
Labels
A-Validation 500 (mostly) errors due to lack of event/parameter validation z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)

Comments

@matrixbot
Copy link
Member

Report by @​tfheen:matrix.org

mars 25 16:27:18 nixos.err.no synapse[19614]: synapse.access.http.8008: [POST-27] 178.255.151.162 - 8008 - Received request: POST /_matrix/client/api/v1/rooms/!txZowdOZZbUjfeOONe:err.no/invite?access_token=<redacted>
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.http.outbound: [POST-27] {PUT-O-1} [matrix.org, @&#8203;tfheen:err.no] Sending request: PUT matrix://matrix.org, @&#8203;tfheen:err.no/_matrix/federation/v1/invite/!txZowdOZZbUjfeOONe:err.no/$14589196388vQnQW:err.no
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.http.matrixfederationclient: [POST-27] {PUT-O-1} Sending request failed to matrix.org, @&#8203;tfheen:err.no: PUT matrix://matrix.org, @&#8203;tfheen:err.no/_matrix/federation/v1/invite/!txZowdOZZbUjfeOONe:err.no/$14589196388vQnQW:err.no: ValueError - ValueError: invalid literal for int() with base 10: 'err.no'
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [GET-28] 178.255.151.162 - 8008 - Received request: GET /_matrix/client/api/v1/rooms/!txZowdOZZbUjfeOONe:err.no/messages?access_token=<redacted>&dir=b&from=t1-1_3_0_1_1&limit=30
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [GET-28] 178.255.151.162 - 8008 - {@&#8203;tfheen:err.no} Processed request: 8ms (6ms, 0ms) (0ms/2) 62B 200 "GET /_matrix/client/api/v1/rooms/!txZowdOZZbUjfeOONe:err.no/messages?access_token=<redacted>&dir=b&from=t1-1_3_0_1_1&limit=30 HTTP/1.1" "matrixConsole/0.6.2 (iPhone; iOS 9.3; Scale/2.00)"
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [POST-29] 178.255.151.162 - 8008 - Received request: POST /_matrix/client/v2_alpha/rooms/!txZowdOZZbUjfeOONe:err.no/receipt/m.read/$14589196387figCO:err.no?access_token=<redacted>
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [POST-29] 178.255.151.162 - 8008 - {@&#8203;tfheen:err.no} Processed request: 105ms (4ms, 0ms) (97ms/2) 22B 200 "POST /_matrix/client/v2_alpha/rooms/!txZowdOZZbUjfeOONe:err.no/receipt/m.read/$14589196387figCO:err.no?access_token=<redacted> HTTP/1.1" "matrixConsole/0.6.2 (iPhone; iOS 9.3; Scale/2.00)"
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [GET-26] 178.255.151.162 - 8008 - {@&#8203;tfheen:err.no} Processed request: 506ms (4ms, 2ms) (6ms/4) 245B 200 "GET /_matrix/client/v2_alpha/sync?access_token=<redacted>&since=s9_3_0_1_1&timeout=30000 HTTP/1.1" "matrixConsole/0.6.2 (iPhone; iOS 9.3; Scale/2.00)"
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [GET-30] 178.255.151.162 - 8008 - Received request: GET /_matrix/client/v2_alpha/sync?access_token=<redacted>&since=s9_3_0_2_1&timeout=30000
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.rest.client.v2_alpha.sync: [GET-30] /sync: user=DomainSpecificString(localpart=u'tfheen', domain=u'err.no'), timeout=30000, since='s9_3_0_2_1', set_presence='online', filter_id=None
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.http.matrixfederationclient: [POST-27] {PUT-O-1} Sending request failed to matrix.org, @&#8203;tfheen:err.no: PUT matrix://matrix.org, @&#8203;tfheen:err.no/_matrix/federation/v1/invite/!txZowdOZZbUjfeOONe:err.no/$14589196388vQnQW:err.no: ValueError - ValueError: invalid literal for int() with base 10: 'err.no'
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [PUT-31] 178.255.151.162 - 8008 - Received request: PUT /_matrix/client/api/v1/rooms/!txZowdOZZbUjfeOONe:err.no/typing/@&#8203;tfheen:err.no?access_token=<redacted>
mars 25 16:27:19 nixos.err.no synapse[19614]: synapse.access.http.8008: [PUT-31] 178.255.151.162 - 8008 - {@&#8203;tfheen:err.no} Processed request: 4ms (4ms, 0ms) (0ms/0) 22B 200 "PUT /_matrix/client/api/v1/rooms/!txZowdOZZbUjfeOONe:err.no/typing/@&#8203;tfheen:err.no?access_token=<redacted> HTTP/1.1" "matrixConsole/0.6.2 (iPhone; iOS 9.3; Scale/2.00)"
mars 25 16:27:20 nixos.err.no synapse[19614]: synapse.http.matrixfederationclient: [POST-27] {PUT-O-1} Sending request failed to matrix.org, @&#8203;tfheen:err.no: PUT matrix://matrix.org, @&#8203;tfheen:err.no/_matrix/federation/v1/invite/!txZowdOZZbUjfeOONe:err.no/$14589196388vQnQW:err.no: ValueError - ValueError: invalid literal for int() with base 10: 'err.no'
mars 25 16:27:22 nixos.err.no synapse[19614]: synapse.http.matrixfederationclient: [POST-27] {PUT-O-1} Sending request failed to matrix.org, @&#8203;tfheen:err.no: PUT matrix://matrix.org, @&#8203;tfheen:err.no/_matrix/federation/v1/invite/!txZowdOZZbUjfeOONe:err.no/$14589196388vQnQW:err.no: ValueError - ValueError: invalid literal for int() with base 10: 'err.no'
mars 25 16:27:22 nixos.err.no synapse[19614]: synapse.http.outbound: [POST-27] {PUT-O-1} [matrix.org, @&#8203;tfheen:err.no] Result: ValueError - ValueError: invalid literal for int() with base 10: 'err.no'
mars 25 16:27:22 nixos.err.no synapse[19614]: synapse.http.server: [POST-27] Failed handle request synapse.http.server._async_render on <synapse.rest.ClientRestResource object at 0x7f9cb90ca110>: <SynapseRequest at 0x7f9cb627d878 method=POST uri=/_matrix/client/api/v1/rooms/!txZowdOZZbUjfeOONe:err.no/invite?access_token=<redacted> clientproto=HTTP/1.1 site=8008>
                                              Traceback (most recent call last):
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/http/server.py", line 104, in wrapped_request_handler
                                                  yield d
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/http/server.py", line 235, in _async_render
                                                  callback_return = yield callback(request, *args)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/rest/client/v1/room.py", line 489, in on_POST
                                                  is_guest=is_guest,
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/handlers/message.py", line 232, in create_and_send_event
                                                  yield member_handler.change_membership(event, context, is_guest=is_guest)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/handlers/room.py", line 448, in change_membership
                                                  do_auth=do_auth,
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/handlers/room.py", line 600, in _do_local_membership_update
                                                  suppress_auth=(not do_auth),
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/handlers/_base.py", line 238, in handle_new_client_event
                                                  event,
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/handlers/federation.py", line 549, in send_invite
                                                  pdu=event
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/federation/federation_client.py", line 509, in send_invite
                                                  content=pdu.get_pdu_json(time_now),
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/federation/transport/client.py", line 216, in send_invite
                                                  data=content,
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
                                                  result = result.throwExceptionIntoGenerator(g)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
                                                  return g.throw(self.type, self.value, self.tb)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/http/matrixfederationclient.py", line 289, in put_json
                                                  long_retries=long_retries,
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
                                                  result = g.send(result)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/http/matrixfederationclient.py", line 159, in _create_request
                                                  send_request,
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/util/logcontext.py", line 271, in preserve_context_over_fn
                                                  res = fn(*args, **kwargs)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/http/matrixfederationclient.py", line 150, in send_request
                                                  producer
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/util/logcontext.py", line 271, in preserve_context_over_fn
                                                  res = fn(*args, **kwargs)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/web/client.py", line 1594, in request
                                                  endpoint = self._getEndpoint(parsedURI)
                                                File "/nix/store/7wimwv66ag4nra00x23cf949yj01y03w-python2.7-Twisted-15.5.0/lib/python2.7/site-packages/twisted/web/client.py", line 1578, in _getEndpoint
                                                  return self._endpointFactory.endpointForURI(uri)
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/http/matrixfederationclient.py", line 72, in endpointForURI
                                                  ssl_context_factory=self.tls_server_context_factory
                                                File "/nix/store/pi38nkgjs6jr4k6plwmdpgnvq4vz048b-matrix-synapse-0.12.0/lib/python2.7/site-packages/synapse/http/endpoint.py", line 44, in matrix_federation_endpoint
                                                  port = int(domain_port[1]) if domain_port[1:] else None
                                              ValueError: invalid literal for int() with base 10: 'err.no'
mars 25 16:27:22 nixos.err.no synapse[19614]: synapse.access.http.8008: [POST-27] 178.255.151.162 - 8008 - {@&#8203;tfheen:err.no} Processed request: 3654ms (27ms, 4ms) (1ms/3) 67B 500 "POST /_matrix/client/api/v1/rooms/!txZowdOZZbUjfeOONe:err.no/invite?access_token=<redacted> HTTP/1.1" "matrixConsole/0.6.2 (iPhone; iOS 9.3; Scale/2.00)"

(Imported from https://matrix.org/jira/browse/SYN-664)

(Reported by @erikjohnston)
@matrixbot
Copy link
Member Author

Jira watchers: @erikjohnston

@matrixbot
Copy link
Member Author

Logs: https://gist.githubusercontent.com/tfheen/e802ceca794f3dcf5d90/raw/d7bf6557fd836350b52831b2135afca4e6cb50eb/gistfile1.txt

-- @erikjohnston

@matrixbot matrixbot changed the title Creating a room with remote invites fails (SYN-664) Creating a room with remote invites fails (https://github.com/matrix-org/synapse/issues/1521) Nov 7, 2016
@matrixbot matrixbot changed the title Creating a room with remote invites fails (https://github.com/matrix-org/synapse/issues/1521) Creating a room with remote invites fails (SYN-664) Nov 7, 2016
@richvdh
Copy link
Member

richvdh commented May 2, 2017

From a brief skim of the logs, the problem here is that the server is trying to send the invite to matrix.org, @tfheen:err.no, which is obviously not a valid matrix server name. So (a) there is probably insufficient validation on the POST /rooms/<room_id>/invite request, and (b) the client was doing something weird.

@richvdh richvdh changed the title Creating a room with remote invites fails (SYN-664) /invite fails with a 500 error if target MXID is invalid (SYN-664) Nov 7, 2018
@richvdh richvdh added z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution A-Validation 500 (mostly) errors due to lack of event/parameter validation z-p3 (Deprecated Label) labels Jul 3, 2020
@ShadowJonathan
Copy link
Contributor

This should fail with a 400, not with a 500

@ShadowJonathan ShadowJonathan mentioned this issue Feb 24, 2021
Closed
@clokep
Copy link
Contributor

clokep commented Feb 24, 2021

I believe this was fixed by #9071, but the stack has changed enough that it isn't clear.

@clokep clokep closed this as completed Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Validation 500 (mostly) errors due to lack of event/parameter validation z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clokep @richvdh @matrixbot @ShadowJonathan