Synapse doesn't append redacts to the top level for backwards compatibility in v11/MSC2174 rooms

[turt2live]

Description

matrix-org/matrix-spec-proposals#2174 describes:

For backwards-compatibility with older clients, servers should add a redacts property to the top level of m.room.redaction events in newer room versions when serving such events over the Client-Server API.

Empirically, Synapse is not doing this:

Events sent over /sync (and possibly /messages) are lacking the top level field.

Steps to reproduce

Create an MSC2174/MSC3820 room and redact a message.

Homeserver

t2l.io

Synapse Version

N/A

Installation Method

pip (from PyPI)

Database

PostgreSQL

Workers

Multiple workers

Platform

N/A

Configuration

No response

Relevant log output

N/A

Anything else that would be useful to know?

No response

[clokep]

I confirmed this is fixed by #15912:

{
  "type": "m.room.redaction",
  "sender": "@alice:localhost:8480",
  "content": {
    "reason": "asdf",
    "redacts": "$w0hBk82GTyF9bRg7w1HLt4iYYP41VYtuhq0UezOol0k"
  },
  "origin_server_ts": 1689683815471,
  "unsigned": {
    "age": 260863,
    "transaction_id": "m1689683815400.5"
  },
  "event_id": "$uF2gT5i6B03SdAXYlcg4FtMzDvxBRV0fRNyC2XKwYQk",
  "redacts": "$w0hBk82GTyF9bRg7w1HLt4iYYP41VYtuhq0UezOol0k"
}

[clokep]

I realized while writing matrix-org/matrix-spec#1604 that the MSC also says:

For improved compatibility with newer clients, servers should add a redacts property to the content of m.room.redaction events in older room versions when serving such events over the Client-Server API.

We don't do this currently and probably should.